Initial commit
This commit is contained in:
Lina Tawfik
431
test/trigger-validation.test.ts
Normal file
431
test/trigger-validation.test.ts
Normal file
@@ -0,0 +1,431 @@
|
||||
import {
|
||||
checkContainsTrigger,
|
||||
escapeRegExp,
|
||||
} from "../src/github/validation/trigger";
|
||||
import { describe, it, expect } from "bun:test";
|
||||
import {
|
||||
createMockContext,
|
||||
mockIssueAssignedContext,
|
||||
mockIssueCommentContext,
|
||||
mockIssueOpenedContext,
|
||||
mockPullRequestReviewContext,
|
||||
mockPullRequestReviewCommentContext,
|
||||
} from "./mockContext";
|
||||
import type {
|
||||
IssueCommentEvent,
|
||||
IssuesAssignedEvent,
|
||||
IssuesEvent,
|
||||
PullRequestEvent,
|
||||
PullRequestReviewEvent,
|
||||
} from "@octokit/webhooks-types";
|
||||
import type { ParsedGitHubContext } from "../src/github/context";
|
||||
|
||||
describe("checkContainsTrigger", () => {
|
||||
describe("direct prompt trigger", () => {
|
||||
it("should return true when direct prompt is provided", () => {
|
||||
const context = createMockContext({
|
||||
eventName: "issues",
|
||||
eventAction: "opened",
|
||||
inputs: {
|
||||
triggerPhrase: "/claude",
|
||||
assigneeTrigger: "",
|
||||
directPrompt: "Fix the bug in the login form",
|
||||
allowedTools: "",
|
||||
disallowedTools: "",
|
||||
customInstructions: "",
|
||||
},
|
||||
});
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return false when direct prompt is empty", () => {
|
||||
const context = createMockContext({
|
||||
eventName: "issues",
|
||||
eventAction: "opened",
|
||||
payload: {
|
||||
action: "opened",
|
||||
issue: {
|
||||
number: 1,
|
||||
title: "Test Issue",
|
||||
body: "Test body without trigger",
|
||||
created_at: "2023-01-01T00:00:00Z",
|
||||
user: { login: "testuser" },
|
||||
},
|
||||
} as IssuesEvent,
|
||||
inputs: {
|
||||
triggerPhrase: "/claude",
|
||||
assigneeTrigger: "",
|
||||
directPrompt: "",
|
||||
allowedTools: "",
|
||||
disallowedTools: "",
|
||||
customInstructions: "",
|
||||
},
|
||||
});
|
||||
expect(checkContainsTrigger(context)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("assignee trigger", () => {
|
||||
it("should return true when issue is assigned to the trigger user", () => {
|
||||
const context = mockIssueAssignedContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should add @ symbol from assignee trigger", () => {
|
||||
const context = {
|
||||
...mockIssueAssignedContext,
|
||||
inputs: {
|
||||
...mockIssueAssignedContext.inputs,
|
||||
assigneeTrigger: "claude-bot",
|
||||
},
|
||||
};
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return false when issue is assigned to a different user", () => {
|
||||
const context = {
|
||||
...mockIssueAssignedContext,
|
||||
payload: {
|
||||
...mockIssueAssignedContext.payload,
|
||||
issue: {
|
||||
...(mockIssueAssignedContext.payload as IssuesAssignedEvent).issue,
|
||||
assignee: {
|
||||
...(mockIssueAssignedContext.payload as IssuesAssignedEvent).issue
|
||||
.assignee,
|
||||
login: "otherUser",
|
||||
},
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
|
||||
expect(checkContainsTrigger(context)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("issue body and title trigger", () => {
|
||||
it("should return true when issue body contains trigger phrase", () => {
|
||||
const context = mockIssueOpenedContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return true when issue title contains trigger phrase", () => {
|
||||
const context = {
|
||||
...mockIssueOpenedContext,
|
||||
payload: {
|
||||
...mockIssueOpenedContext.payload,
|
||||
issue: {
|
||||
...(mockIssueOpenedContext.payload as IssuesEvent).issue,
|
||||
title: "/claude Fix the login bug",
|
||||
body: "The login page is broken",
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should handle trigger phrase with punctuation", () => {
|
||||
const baseContext = {
|
||||
...mockIssueOpenedContext,
|
||||
inputs: {
|
||||
...mockIssueOpenedContext.inputs,
|
||||
triggerPhrase: "@claude",
|
||||
},
|
||||
};
|
||||
|
||||
// Test various punctuation marks
|
||||
const testCases = [
|
||||
{ issueBody: "@claude, can you help?", expected: true },
|
||||
{ issueBody: "@claude. Please look at this", expected: true },
|
||||
{ issueBody: "@claude! This is urgent", expected: true },
|
||||
{ issueBody: "@claude? What do you think?", expected: true },
|
||||
{ issueBody: "@claude: here's the issue", expected: true },
|
||||
{ issueBody: "@claude; and another thing", expected: true },
|
||||
{ issueBody: "Hey @claude, can you help?", expected: true },
|
||||
{ issueBody: "claudette contains claude", expected: false },
|
||||
{ issueBody: "email@claude.com", expected: false },
|
||||
];
|
||||
|
||||
testCases.forEach(({ issueBody, expected }) => {
|
||||
const context = {
|
||||
...baseContext,
|
||||
payload: {
|
||||
...baseContext.payload,
|
||||
issue: {
|
||||
...(baseContext.payload as IssuesEvent).issue,
|
||||
body: issueBody,
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(expected);
|
||||
});
|
||||
});
|
||||
|
||||
it("should return false when trigger phrase is part of another word", () => {
|
||||
const context = {
|
||||
...mockIssueOpenedContext,
|
||||
payload: {
|
||||
...mockIssueOpenedContext.payload,
|
||||
issue: {
|
||||
...(mockIssueOpenedContext.payload as IssuesEvent).issue,
|
||||
body: "claudette helped me with this",
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(false);
|
||||
});
|
||||
|
||||
it("should handle trigger phrase in title with punctuation", () => {
|
||||
const baseContext = {
|
||||
...mockIssueOpenedContext,
|
||||
inputs: {
|
||||
...mockIssueOpenedContext.inputs,
|
||||
triggerPhrase: "@claude",
|
||||
},
|
||||
};
|
||||
|
||||
const testCases = [
|
||||
{ issueTitle: "@claude, can you help?", expected: true },
|
||||
{ issueTitle: "@claude: Fix this bug", expected: true },
|
||||
{ issueTitle: "Bug: @claude please review", expected: true },
|
||||
{ issueTitle: "email@claude.com issue", expected: false },
|
||||
{ issueTitle: "claudette needs help", expected: false },
|
||||
];
|
||||
|
||||
testCases.forEach(({ issueTitle, expected }) => {
|
||||
const context = {
|
||||
...baseContext,
|
||||
payload: {
|
||||
...baseContext.payload,
|
||||
issue: {
|
||||
...(baseContext.payload as IssuesEvent).issue,
|
||||
title: issueTitle,
|
||||
body: "No trigger in body",
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(expected);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("pull request body and title trigger", () => {
|
||||
it("should return true when PR body contains trigger phrase", () => {
|
||||
const context = createMockContext({
|
||||
eventName: "pull_request",
|
||||
eventAction: "opened",
|
||||
isPR: true,
|
||||
payload: {
|
||||
action: "opened",
|
||||
pull_request: {
|
||||
number: 123,
|
||||
title: "Test PR",
|
||||
body: "@claude can you review this?",
|
||||
created_at: "2023-01-01T00:00:00Z",
|
||||
user: { login: "testuser" },
|
||||
},
|
||||
} as PullRequestEvent,
|
||||
inputs: {
|
||||
triggerPhrase: "@claude",
|
||||
assigneeTrigger: "",
|
||||
directPrompt: "",
|
||||
allowedTools: "",
|
||||
disallowedTools: "",
|
||||
customInstructions: "",
|
||||
},
|
||||
});
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return true when PR title contains trigger phrase", () => {
|
||||
const context = createMockContext({
|
||||
eventName: "pull_request",
|
||||
eventAction: "opened",
|
||||
isPR: true,
|
||||
payload: {
|
||||
action: "opened",
|
||||
pull_request: {
|
||||
number: 123,
|
||||
title: "@claude Review this PR",
|
||||
body: "This PR fixes a bug",
|
||||
created_at: "2023-01-01T00:00:00Z",
|
||||
user: { login: "testuser" },
|
||||
},
|
||||
} as PullRequestEvent,
|
||||
inputs: {
|
||||
triggerPhrase: "@claude",
|
||||
assigneeTrigger: "",
|
||||
directPrompt: "",
|
||||
allowedTools: "",
|
||||
disallowedTools: "",
|
||||
customInstructions: "",
|
||||
},
|
||||
});
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return false when PR body doesn't contain trigger phrase", () => {
|
||||
const context = createMockContext({
|
||||
eventName: "pull_request",
|
||||
eventAction: "opened",
|
||||
isPR: true,
|
||||
payload: {
|
||||
action: "opened",
|
||||
pull_request: {
|
||||
number: 123,
|
||||
title: "Test PR",
|
||||
body: "This PR fixes a bug",
|
||||
created_at: "2023-01-01T00:00:00Z",
|
||||
user: { login: "testuser" },
|
||||
},
|
||||
} as PullRequestEvent,
|
||||
inputs: {
|
||||
triggerPhrase: "@claude",
|
||||
assigneeTrigger: "",
|
||||
directPrompt: "",
|
||||
allowedTools: "",
|
||||
disallowedTools: "",
|
||||
customInstructions: "",
|
||||
},
|
||||
});
|
||||
expect(checkContainsTrigger(context)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("comment trigger", () => {
|
||||
it("should return true for issue_comment with trigger phrase", () => {
|
||||
const context = mockIssueCommentContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return true for pull_request_review_comment with trigger phrase", () => {
|
||||
const context = mockPullRequestReviewCommentContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return true for pull_request_review with submitted action and trigger phrase", () => {
|
||||
const context = mockPullRequestReviewContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return true for pull_request_review with edited action and trigger phrase", () => {
|
||||
const context = {
|
||||
...mockPullRequestReviewContext,
|
||||
eventAction: "edited",
|
||||
payload: {
|
||||
...mockPullRequestReviewContext.payload,
|
||||
action: "edited",
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(true);
|
||||
});
|
||||
|
||||
it("should return false for pull_request_review with different action", () => {
|
||||
const context = {
|
||||
...mockPullRequestReviewContext,
|
||||
eventAction: "dismissed",
|
||||
payload: {
|
||||
...mockPullRequestReviewContext.payload,
|
||||
action: "dismissed",
|
||||
review: {
|
||||
...(mockPullRequestReviewContext.payload as PullRequestReviewEvent)
|
||||
.review,
|
||||
body: "/claude please review this PR",
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(false);
|
||||
});
|
||||
|
||||
it("should handle pull_request_review with punctuation", () => {
|
||||
const baseContext = {
|
||||
...mockPullRequestReviewContext,
|
||||
inputs: {
|
||||
...mockPullRequestReviewContext.inputs,
|
||||
triggerPhrase: "@claude",
|
||||
},
|
||||
};
|
||||
|
||||
const testCases = [
|
||||
{ commentBody: "@claude, please review", expected: true },
|
||||
{ commentBody: "@claude. fix this", expected: true },
|
||||
{ commentBody: "@claude!", expected: true },
|
||||
{ commentBody: "claude@example.com", expected: false },
|
||||
{ commentBody: "claudette", expected: false },
|
||||
];
|
||||
|
||||
testCases.forEach(({ commentBody, expected }) => {
|
||||
const context = {
|
||||
...baseContext,
|
||||
payload: {
|
||||
...baseContext.payload,
|
||||
review: {
|
||||
...(baseContext.payload as PullRequestReviewEvent).review,
|
||||
body: commentBody,
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(expected);
|
||||
});
|
||||
});
|
||||
|
||||
it("should handle comment trigger with punctuation", () => {
|
||||
const baseContext = {
|
||||
...mockIssueCommentContext,
|
||||
inputs: {
|
||||
...mockIssueCommentContext.inputs,
|
||||
triggerPhrase: "@claude",
|
||||
},
|
||||
};
|
||||
|
||||
const testCases = [
|
||||
{ commentBody: "@claude, please review", expected: true },
|
||||
{ commentBody: "@claude. fix this", expected: true },
|
||||
{ commentBody: "@claude!", expected: true },
|
||||
{ commentBody: "claude@example.com", expected: false },
|
||||
{ commentBody: "claudette", expected: false },
|
||||
];
|
||||
|
||||
testCases.forEach(({ commentBody, expected }) => {
|
||||
const context = {
|
||||
...baseContext,
|
||||
payload: {
|
||||
...baseContext.payload,
|
||||
comment: {
|
||||
...(baseContext.payload as IssueCommentEvent).comment,
|
||||
body: commentBody,
|
||||
},
|
||||
},
|
||||
} as ParsedGitHubContext;
|
||||
expect(checkContainsTrigger(context)).toBe(expected);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("non-matching events", () => {
|
||||
it("should return false for non-matching event type", () => {
|
||||
const context = createMockContext({
|
||||
eventName: "push",
|
||||
eventAction: "created",
|
||||
payload: {} as any,
|
||||
});
|
||||
expect(checkContainsTrigger(context)).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("escapeRegExp", () => {
|
||||
it("should escape special regex characters", () => {
|
||||
expect(escapeRegExp(".*+?^${}()|[]\\")).toBe(
|
||||
"\\.\\*\\+\\?\\^\\$\\{\\}\\(\\)\\|\\[\\]\\\\",
|
||||
);
|
||||
});
|
||||
|
||||
it("should not escape regular characters", () => {
|
||||
expect(escapeRegExp("abc123")).toBe("abc123");
|
||||
});
|
||||
|
||||
it("should handle mixed characters", () => {
|
||||
expect(escapeRegExp("hello.world")).toBe("hello\\.world");
|
||||
expect(escapeRegExp("test[123]")).toBe("test\\[123\\]");
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user