feat: add base_branch input to specify source branch for new Claude branches (#72)
* feat: add base_branch input to specify source branch for new Claude branches - Add base_branch input parameter to action.yml allowing users to specify which branch to use as source - Update setupBranch function to accept and use the base branch parameter - Defaults to repository default branch if no base branch is specified - Addresses issue #62 for better branch control Co-authored-by: ashwin-ant <ashwin-ant@users.noreply.github.com> * perf: optimize setupBranch to avoid unnecessary default branch fetch Only fetch repository default branch when actually needed: - Skip initial fetch when baseBranch is provided - Fetch default branch at end only for return value and GitHub Actions output - Eliminates unnecessary API call when users specify base branch Co-authored-by: ashwin-ant <ashwin-ant@users.noreply.github.com> * fix: properly handle base branch throughout the action workflow - Fix TypeScript error where defaultBranch was used before being assigned - Replace DEFAULT_BRANCH with BASE_BRANCH in subsequent workflow steps - Update PR creation and branch comparison to use the actual base branch - Ensure custom base_branch input is respected in all operations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: move BASE_BRANCH env reading into parseGitHubContext - Move BASE_BRANCH environment variable reading into parseGitHubContext for consistency - Update setupBranch to use context.inputs.baseBranch instead of process.env - Fix test descriptions to correctly reference BASE_BRANCH instead of DEFAULT_BRANCH - Update test environment setup to use BASE_BRANCH 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: ashwin-ant <ashwin-ant@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -127,7 +127,7 @@ describe("generatePrompt", () => {
|
||||
eventName: "issue_comment",
|
||||
commentId: "67890",
|
||||
isPR: false,
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-67890-20240101_120000",
|
||||
issueNumber: "67890",
|
||||
commentBody: "@claude please fix this",
|
||||
@@ -183,7 +183,7 @@ describe("generatePrompt", () => {
|
||||
eventAction: "opened",
|
||||
isPR: false,
|
||||
issueNumber: "789",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-789-20240101_120000",
|
||||
},
|
||||
};
|
||||
@@ -210,7 +210,7 @@ describe("generatePrompt", () => {
|
||||
eventAction: "assigned",
|
||||
isPR: false,
|
||||
issueNumber: "999",
|
||||
defaultBranch: "develop",
|
||||
baseBranch: "develop",
|
||||
claudeBranch: "claude/issue-999-20240101_120000",
|
||||
assigneeTrigger: "claude-bot",
|
||||
},
|
||||
@@ -238,7 +238,7 @@ describe("generatePrompt", () => {
|
||||
eventAction: "opened",
|
||||
isPR: false,
|
||||
issueNumber: "789",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-789-20240101_120000",
|
||||
},
|
||||
};
|
||||
@@ -285,7 +285,7 @@ describe("generatePrompt", () => {
|
||||
commentId: "67890",
|
||||
isPR: false,
|
||||
issueNumber: "123",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-67890-20240101_120000",
|
||||
commentBody: "@claude please fix this",
|
||||
},
|
||||
@@ -307,7 +307,7 @@ describe("generatePrompt", () => {
|
||||
commentId: "67890",
|
||||
isPR: false,
|
||||
issueNumber: "123",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-67890-20240101_120000",
|
||||
commentBody: "@claude please fix this",
|
||||
},
|
||||
@@ -362,7 +362,7 @@ describe("generatePrompt", () => {
|
||||
eventAction: "opened",
|
||||
isPR: false,
|
||||
issueNumber: "789",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-789-20240101_120000",
|
||||
},
|
||||
};
|
||||
@@ -400,7 +400,7 @@ describe("generatePrompt", () => {
|
||||
commentId: "67890",
|
||||
isPR: false,
|
||||
issueNumber: "123",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-123-20240101_120000",
|
||||
commentBody: "@claude please fix this",
|
||||
},
|
||||
@@ -432,7 +432,7 @@ describe("generatePrompt", () => {
|
||||
prNumber: "456",
|
||||
commentBody: "@claude please fix this",
|
||||
claudeBranch: "claude/pr-456-20240101_120000",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
},
|
||||
};
|
||||
|
||||
@@ -470,7 +470,7 @@ describe("generatePrompt", () => {
|
||||
isPR: true,
|
||||
prNumber: "456",
|
||||
commentBody: "@claude please fix this",
|
||||
// No claudeBranch or defaultBranch for open PRs
|
||||
// No claudeBranch or baseBranch for open PRs
|
||||
},
|
||||
};
|
||||
|
||||
@@ -503,7 +503,7 @@ describe("generatePrompt", () => {
|
||||
prNumber: "789",
|
||||
commentBody: "@claude please update this",
|
||||
claudeBranch: "claude/pr-789-20240101_123000",
|
||||
defaultBranch: "develop",
|
||||
baseBranch: "develop",
|
||||
},
|
||||
};
|
||||
|
||||
@@ -531,7 +531,7 @@ describe("generatePrompt", () => {
|
||||
commentId: "review-comment-123",
|
||||
commentBody: "@claude fix this issue",
|
||||
claudeBranch: "claude/pr-999-20240101_140000",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
},
|
||||
};
|
||||
|
||||
@@ -559,7 +559,7 @@ describe("generatePrompt", () => {
|
||||
isPR: true,
|
||||
prNumber: "555",
|
||||
claudeBranch: "claude/pr-555-20240101_150000",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
},
|
||||
};
|
||||
|
||||
@@ -604,7 +604,7 @@ describe("getEventTypeAndContext", () => {
|
||||
eventAction: "assigned",
|
||||
isPR: false,
|
||||
issueNumber: "999",
|
||||
defaultBranch: "main",
|
||||
baseBranch: "main",
|
||||
claudeBranch: "claude/issue-999-20240101_120000",
|
||||
assigneeTrigger: "claude-bot",
|
||||
},
|
||||
|
||||
@@ -34,7 +34,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
beforeEach(() => {
|
||||
process.env = {
|
||||
...BASE_ENV,
|
||||
DEFAULT_BRANCH: "main",
|
||||
BASE_BRANCH: "main",
|
||||
CLAUDE_BRANCH: "claude/issue-67890-20240101_120000",
|
||||
};
|
||||
});
|
||||
@@ -62,7 +62,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
expect(result.eventData.claudeBranch).toBe(
|
||||
"claude/issue-67890-20240101_120000",
|
||||
);
|
||||
expect(result.eventData.defaultBranch).toBe("main");
|
||||
expect(result.eventData.baseBranch).toBe("main");
|
||||
expect(result.eventData.commentBody).toBe(
|
||||
"@claude can you help explain how to configure the logging system?",
|
||||
);
|
||||
@@ -75,7 +75,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
).toThrow("CLAUDE_BRANCH is required for issue_comment event");
|
||||
});
|
||||
|
||||
test("should throw error when DEFAULT_BRANCH is missing", () => {
|
||||
test("should throw error when BASE_BRANCH is missing", () => {
|
||||
expect(() =>
|
||||
prepareContext(
|
||||
mockIssueCommentContext,
|
||||
@@ -83,7 +83,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
undefined,
|
||||
"claude/issue-67890-20240101_120000",
|
||||
),
|
||||
).toThrow("DEFAULT_BRANCH is required for issue_comment event");
|
||||
).toThrow("BASE_BRANCH is required for issue_comment event");
|
||||
});
|
||||
});
|
||||
|
||||
@@ -151,7 +151,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
beforeEach(() => {
|
||||
process.env = {
|
||||
...BASE_ENV,
|
||||
DEFAULT_BRANCH: "main",
|
||||
BASE_BRANCH: "main",
|
||||
CLAUDE_BRANCH: "claude/issue-42-20240101_120000",
|
||||
};
|
||||
});
|
||||
@@ -172,7 +172,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
result.eventData.eventAction === "opened"
|
||||
) {
|
||||
expect(result.eventData.issueNumber).toBe("42");
|
||||
expect(result.eventData.defaultBranch).toBe("main");
|
||||
expect(result.eventData.baseBranch).toBe("main");
|
||||
expect(result.eventData.claudeBranch).toBe(
|
||||
"claude/issue-42-20240101_120000",
|
||||
);
|
||||
@@ -195,7 +195,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
result.eventData.eventAction === "assigned"
|
||||
) {
|
||||
expect(result.eventData.issueNumber).toBe("123");
|
||||
expect(result.eventData.defaultBranch).toBe("main");
|
||||
expect(result.eventData.baseBranch).toBe("main");
|
||||
expect(result.eventData.claudeBranch).toBe(
|
||||
"claude/issue-123-20240101_120000",
|
||||
);
|
||||
@@ -209,7 +209,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
).toThrow("CLAUDE_BRANCH is required for issues event");
|
||||
});
|
||||
|
||||
test("should throw error when DEFAULT_BRANCH is missing for issues", () => {
|
||||
test("should throw error when BASE_BRANCH is missing for issues", () => {
|
||||
expect(() =>
|
||||
prepareContext(
|
||||
mockIssueOpenedContext,
|
||||
@@ -217,7 +217,7 @@ describe("parseEnvVarsWithContext", () => {
|
||||
undefined,
|
||||
"claude/issue-42-20240101_120000",
|
||||
),
|
||||
).toThrow("DEFAULT_BRANCH is required for issues event");
|
||||
).toThrow("BASE_BRANCH is required for issues event");
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user